Runtime moduli #134
Merged
Runtime moduli #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Nov 21, 2022
| @@ -1,17 +1,62 @@ | |||
| use crate::UInt; | |||
There was a problem hiding this comment.
This PR looks good aside from the use of the 2015 edition module style (i.e. mod.rs)
We've adopted the 2018 edition module style, where this file would be modular.rs.
Unfortunately I don't think they ever added a lint for mixed module styles.
There was a problem hiding this comment.
Is this what you mean?:
https://rust-lang.github.io/rust-clippy/master/index.html#mod_module_files
There was a problem hiding this comment.
Oh ho, went looking for that the other day and didn't find it... weird
|
Will fix it up retroactively |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends #130. It adds residues for moduli decided at run-time.